MazterQyou commented on code in PR #1836:
URL: https://github.com/apache/arrow-rs/pull/1836#discussion_r894966007
##########
arrow/src/compute/kernels/temporal.rs:
##########
@@ -112,6 +112,32 @@ macro_rules! return_compute_error_with {
};
}
+trait ChronoDateQuarter {
+ fn quarter(&self) -> u32;
+
+ fn quarter0(&self) -> u32;
Review Comment:
There's no particular reason to have quarter0 at the moment, but `chrono`
implements those `0` getters so I followd. I thought it might be more
future-proof that way, besides the fact one could be based on another.
If you think `quarter0` should not be there because it serve no purpose at
the moment, I can refactor the trait to have only `quarter` fn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
