thinkharderdev commented on code in PR #68:
URL: https://github.com/apache/arrow-ballista/pull/68#discussion_r898160457
##########
ballista/rust/core/src/serde/physical_plan/mod.rs:
##########
@@ -235,7 +235,11 @@ impl AsExecutionPlan for PhysicalPlanNode {
PhysicalPlanType::GlobalLimit(limit) => {
let input: Arc<dyn ExecutionPlan> =
into_physical_plan!(limit.input, registry, runtime,
extension_codec)?;
- Ok(Arc::new(GlobalLimitExec::new(input, limit.limit as usize)))
+ Ok(Arc::new(GlobalLimitExec::new(
Review Comment:
Actually there was a bug in that version :) See the fix here
https://github.com/coralogix/arrow-ballista/pull/1/commits/830b2d58a13710bb3e28337be5a641716155487e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
