[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1893: Correct nullable in read_dictionary

[GitBox]

tustvold commented on code in PR #1893:
URL: https://github.com/apache/arrow-rs/pull/1893#discussion_r899987365


##########
arrow/src/ipc/reader.rs:
##########
@@ -702,7 +702,11 @@ pub fn read_dictionary(
         DataType::Dictionary(_, ref value_type) => {
             // Make a fake schema for the dictionary batch.
             let schema = Schema {
-                fields: vec![Field::new("", value_type.as_ref().clone(), 
false)],
+                fields: vec![Field::new(
+                    "",
+                    value_type.as_ref().clone(),
+                    first_field.is_nullable(),

Review Comment:
   Should it not be nullable = true, as we don't actually know if the 
dictionary values may or may not contain nulls?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org