marsupialtail commented on code in PR #13385:
URL: https://github.com/apache/arrow/pull/13385#discussion_r900691273
##########
cpp/src/arrow/filesystem/s3fs.h:
##########
@@ -102,6 +102,8 @@ struct ARROW_EXPORT S3Options {
/// the region (environment variables, configuration profile, EC2 metadata
/// server).
std::string region;
+ long request_timeout_ms = -1;
+ long connect_timeout_ms = -1;
Review Comment:
@pitrou So changing it to double actually is a bit problematic because the
underlying AWS config data types are long. We'd have to convert them back to
long if we use double here. Please let me know what you'd prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
