kou commented on code in PR #12914: URL: https://github.com/apache/arrow/pull/12914#discussion_r901364218
########## cpp/cmake_modules/SetupCxxFlags.cmake: ########## @@ -118,12 +118,16 @@ if(NOT DEFINED CMAKE_C_STANDARD) set(CMAKE_C_STANDARD 11) endif() -# This ensures that things like c++11 get passed correctly +# This ensures that things like c++11/c++14 get passed correctly if(NOT DEFINED CMAKE_CXX_STANDARD) - set(CMAKE_CXX_STANDARD 11) + if(ARROW_AZURE) + set(CMAKE_CXX_STANDARD 14) Review Comment: Note that we need a C++14 compatible compiler for `-DARROW_AZURE=ON` even if we choose either the `CMAKE_CXX_STANDARD=14` approach or the object library approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
