vibhatha commented on PR #13401: URL: https://github.com/apache/arrow/pull/13401#issuecomment-1160235282
> I don't feel qualified to comment on those design questions, but FWIW, I ran the serialized output of the test case through the validator and it's okay-ish (the validator doesn't like the lack of a `NULLABILITY_REQUIRED` in the struct that represents the schema, but that's pretty pedantic I guess), and the code looks fine to me. Thanks a lot for the quick check on this. It’s very interesting how you validated things using the tool. Do you think it’s wise to add a CI to test Substrait related queries using this tool? Please feel free to add suggestions. @jvanstraten One doubtful thing is to check in serialization is whether a projection or filter expression is added or not/ differentiation from default values. For instance filter expression defaults to a boolean literal of value true. cc @westonpace For future reference in the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
