[GitHub] [arrow-datafusion] AssHero commented on a diff in pull request #2750: try to reduce left/right/full join to inner join

[GitBox]

AssHero commented on code in PR #2750:
URL: https://github.com/apache/arrow-datafusion/pull/2750#discussion_r902105760


##########
datafusion/sql/src/planner.rs:
##########
@@ -784,6 +784,9 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
 
                 let filter_expr = self.sql_to_rex(predicate_expr, 
&join_schema, ctes)?;
 
+                // reduce outer joins
+                let plans = reduce_outer_joins(plans, &filter_expr)?;

Review Comment:
   > I'm not sure that whether this should be done here, or somewhere else like 
in optimize phase. Other parts are great ❤️ cc @alamb
   
   Here we have joins and quals from where and these make reduce possible.  
Please give me your suggestions, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org