AssHero commented on code in PR #2721: URL: https://github.com/apache/arrow-datafusion/pull/2721#discussion_r903699415
########## datafusion/core/src/physical_plan/hash_join.rs: ########## @@ -1054,6 +1110,116 @@ fn equal_rows( DataType::LargeUtf8 => { equal_rows_elem!(LargeStringArray, l, r, left, right, null_equals_null) } + DataType::Decimal(_, lscale) => match r.data_type() { Review Comment: > yes, we should check the data types and make the coercion in the planner. I'll create an issue and follow up the pr later. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org