nealrichardson commented on code in PR #13429:
URL: https://github.com/apache/arrow/pull/13429#discussion_r905470325
##########
r/tools/nixlibs.R:
##########
@@ -404,8 +404,10 @@ ensure_cmake <- function() {
cmake
}
-find_cmake <- function(paths, version_required = 3.10) {
+find_cmake <- function(paths, version_required = "3.10") {
# Given a list of possible cmake paths, return the first one that exists and
is new enough
+ # version_required should be a strong or packageVersion; numeric version
Review Comment:
oof thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
