pitrou commented on code in PR #13437:
URL: https://github.com/apache/arrow/pull/13437#discussion_r909418536
##########
cpp/src/arrow/csv/parser.cc:
##########
@@ -296,6 +297,9 @@ class BlockParserImpl {
if (UseBulkFilter) {
const char* bulk_end = RunBulkFilter(parsed_writer, data, data_end,
bulk_filter);
if (ARROW_PREDICT_FALSE(bulk_end == nullptr)) {
+ if (is_final) {
+ final_offset = static_cast<int32_t>(data_end - data);
Review Comment:
I think the current code is incorrect in this situation: `HandleInvalidRow`
is using `util::string_view(start, data - start)` as the invalid row span.
https://github.com/apache/arrow/blob/master/cpp/src/arrow/csv/parser.cc#L203-L215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
