avantgardnerio commented on code in PR #2797:
URL: https://github.com/apache/arrow-datafusion/pull/2797#discussion_r910184783
##########
datafusion/optimizer/src/simplify_expressions.rs:
##########
@@ -1963,10 +1963,10 @@ mod tests {
// Note that constant folder runs and folds the entire
// expression down to a single constant (true)
- let expected = "Projection: Date32(\"18636\") AS
CAST(totimestamp(Utf8(\"2020-09-08T12:05:00+00:00\")) AS Date32) +
IntervalDayTime(\"123\")\
- \n TableScan: test";
+ let expected = r#"Projection: Date32("18636") AS
CAST(totimestamp(Utf8("2020-09-08T12:05:00+00:00")) AS Date32) +
IntervalDayTime("528280977408")
+ TableScan: test"#;
let actual = get_optimized_plan_formatted(&plan, &time);
- assert_eq!(expected, actual);
+ assert_eq!(actual, expected);
Review Comment:
JetBrains products assume `actual` is on the left when visualizing diffs.
The `assert_eq!` macro seems to not specify, so I updated it to look correct in
my IDE so as to be less confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
