westonpace commented on code in PR #13366: URL: https://github.com/apache/arrow/pull/13366#discussion_r910249487
########## cpp/src/arrow/util/benchmark_util.h: ########## @@ -15,10 +15,24 @@ // specific language governing permissions and limitations // under the License. +#include <condition_variable> +#include <mutex> Review Comment: Ah, this is going to be a problem. We can't include `mutex` in public headers due to a Windows compatibility issue. Can you create a `benchmark_util.cc` and move the definition of these methods there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
