tachyonwill commented on code in PR #13456:
URL: https://github.com/apache/arrow/pull/13456#discussion_r910462791
##########
cpp/src/parquet/schema_test.cc:
##########
@@ -1691,6 +1691,18 @@ TEST(TestSchemaNodeCreation, FactoryExceptions) {
// Primitive too small for given precision ...
ASSERT_ANY_THROW(PrimitiveNode::Make("decimal", Repetition::REQUIRED,
DecimalLogicalType::Make(16, 6),
Type::INT32));
+ ASSERT_ANY_THROW(PrimitiveNode::Make("decimal", Repetition::REQUIRED,
+ DecimalLogicalType::Make(10, 9),
Type::INT32));
+ ASSERT_ANY_THROW(PrimitiveNode::Make("decimal", Repetition::REQUIRED,
+ DecimalLogicalType::Make(17, 18),
Type::INT64));
Review Comment:
Yes, added a comment and a new test with precision=19.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
