Ted-Jiang commented on PR #1977:
URL: https://github.com/apache/arrow-rs/pull/1977#issuecomment-1172057493
> should be calculated during the predicate pushdown.
Yes, i agree it's better keep it private.
But in current code base we not have a `filter` struct like in java to
provide predicate pushdown.
Like datafusion use 'mask' (level for column), 'row ranges' is like a
*page_mask*
```
fn get_record_reader_by_columns(
&mut self,
mask: ProjectionMask,
batch_size: usize,
) -> Result<ParquetRecordBatchReader> {
```
I think for now, we make it pub, after full support for predicate pushdown,
we will do like in java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
