rok commented on code in PR #13462:
URL: https://github.com/apache/arrow/pull/13462#discussion_r913242557
##########
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc:
##########
@@ -409,6 +409,60 @@ class ScalarTemporalTest : public ::testing::Test {
RoundTemporalOptions(15, CalendarUnit::QUARTER);
RoundTemporalOptions round_to_15_years = RoundTemporalOptions(15,
CalendarUnit::YEAR);
+ RoundTemporalOptions round_to_1_nanoseconds_2 =
+ RoundTemporalOptions(1, CalendarUnit::NANOSECOND, true, true, false);
Review Comment:
Yes! Done.
##########
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc:
##########
@@ -409,6 +409,60 @@ class ScalarTemporalTest : public ::testing::Test {
RoundTemporalOptions(15, CalendarUnit::QUARTER);
RoundTemporalOptions round_to_15_years = RoundTemporalOptions(15,
CalendarUnit::YEAR);
+ RoundTemporalOptions round_to_1_nanoseconds_2 =
+ RoundTemporalOptions(1, CalendarUnit::NANOSECOND, true, true, false);
+ RoundTemporalOptions round_to_1_microseconds_2 =
+ RoundTemporalOptions(1, CalendarUnit::MICROSECOND, true, true, false);
+ RoundTemporalOptions round_to_1_milliseconds_2 =
+ RoundTemporalOptions(1, CalendarUnit::MILLISECOND, true, true, false);
+ RoundTemporalOptions round_to_1_seconds_2 =
+ RoundTemporalOptions(1, CalendarUnit::SECOND, true, true, false);
+ RoundTemporalOptions round_to_1_minutes_2 =
+ RoundTemporalOptions(1, CalendarUnit::MINUTE, true, true, false);
+ RoundTemporalOptions round_to_1_hours_2 =
+ RoundTemporalOptions(1, CalendarUnit::HOUR, true, true, false);
+ RoundTemporalOptions round_to_1_days_2 =
+ RoundTemporalOptions(1, CalendarUnit::DAY, true, true, false);
+ RoundTemporalOptions round_to_1_weeks_2 =
+ RoundTemporalOptions(1, CalendarUnit::WEEK, true, true, false);
+ RoundTemporalOptions round_to_1_weeks_sunday_2 =
+ RoundTemporalOptions(1, CalendarUnit::WEEK, false, true, false);
+ RoundTemporalOptions round_to_1_months_2 =
+ RoundTemporalOptions(1, CalendarUnit::MONTH, true, true, false);
+ RoundTemporalOptions round_to_1_quarters_2 =
+ RoundTemporalOptions(1, CalendarUnit::QUARTER, true, true, false);
+ RoundTemporalOptions round_to_1_years_2 =
+ RoundTemporalOptions(1, CalendarUnit::YEAR, true, true, false);
+
+ RoundTemporalOptions round_to_15_nanoseconds_2 =
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
