lidavidm commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r913801756
##########
cpp/src/arrow/dataset/file_base.cc:
##########
@@ -89,6 +89,12 @@ Result<std::shared_ptr<io::InputStream>>
FileSource::OpenCompressed(
return io::CompressedInputStream::Make(codec.get(), std::move(file));
}
+bool FileSource::Equals(const FileSource& other) const {
+ if (filesystem_ == NULLPTR) return false;
Review Comment:
Can filesystem_ be null? I would have assumed not given this is a
FileFragment (and it should be validated in the constructor)
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -114,6 +114,9 @@ class ARROW_DS_EXPORT FileSource {
Result<std::shared_ptr<io::InputStream>> OpenCompressed(
util::optional<Compression::type> compression = util::nullopt) const;
+ /// \brief equality comparison with another FileSource
+ bool Equals(const FileSource& other) const;
Review Comment:
I don't see the change for FileSource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
