nealrichardson commented on code in PR #13517:
URL: https://github.com/apache/arrow/pull/13517#discussion_r914078793
##########
r/R/dplyr-funcs-math.R:
##########
@@ -80,4 +80,21 @@ register_bindings_math <- function() {
options = list(ndigits = digits, round_mode = RoundMode$HALF_TO_EVEN)
)
})
+
+ register_binding("sqrt", function(x, ...) {
+ # accepts and ignores ... for consistency with base::trunc()
Review Comment:
I think you can drop `...` from the signature and these comments because the
`base::` versions of these particular functions don't take dots:
```
> sqrt
function (x) .Primitive("sqrt")
> exp
function (x) .Primitive("exp")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
