paleolimbot commented on code in PR #13440:
URL: https://github.com/apache/arrow/pull/13440#discussion_r914796111
##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -533,6 +533,21 @@ test_that("extract yday from timestamp", {
)
})
+test_that("extract qday from timestamp", {
+ compare_dplyr_binding(
+ .input %>%
+ mutate(x = qday(datetime)) %>%
+ collect(),
+ test_df
Review Comment:
You could try that and see how long it takes...it might only be a few ms and
then I'd say keep it in the regular test suite. We do have a mechanism for
running extra tests but right now it's limited to the large memory tests (via
the env var ARROW_LARGE_MEMORY_TESTS). Given that a single real-world poke at
this exposed an error, I'd say at least a year is a must in our normal test
suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
