nealrichardson commented on code in PR #13241: URL: https://github.com/apache/arrow/pull/13241#discussion_r916267584
########## r/NEWS.md: ########## @@ -19,6 +19,8 @@ # arrow 8.0.0.9000 +* The `arrow.dev_repo` for nightly builds of the R package and prebuilt + ibarrow binaries is now https://nightlies.apache.org/arrow/r. Review Comment: ```suggestion libarrow binaries is now https://nightlies.apache.org/arrow/r/. ``` ########## docs/source/developers/guide/resources.rst: ########## @@ -55,7 +55,7 @@ Additional information It is possible to install the Arrow R package from the nightly builds which are daily development builds of the R package and are not the official releases. See more on the - `Install R package article <https://ursalabs.org/arrow-r-nightly/articles/install.html#install-the-nightly-build>`_. + `Install R package article <https://arrow.apache.org/docs/r/articles/install.html#install-the-nightly-build>`_. Review Comment: Previously this pointed to the nightly docs, which I guess makes sense because this is about the nightly packages and the installation instructions for those may change, well, nightly. Is it worth keeping the nightly docs URL? ```suggestion `Install R package article <https://arrow.apache.org/docs/dev/r/articles/install.html#install-the-nightly-build>`_. ``` ########## r/vignettes/developers/setup.Rmd: ########## @@ -45,14 +45,13 @@ recent version of the library without building from source. ### Linux On Linux, you can download a .zip file containing libarrow from the -nightly repository. +[nightly repository](https://nightlies.apache.org/arrow/r/libarrow/bin). Review Comment: ```suggestion [nightly repository](https://nightlies.apache.org/arrow/r/libarrow/bin/). ``` ########## r/README.md: ########## @@ -75,11 +75,11 @@ and thus are only available in R >= 4.0. ### Installing a development version Development versions of the package (binary and source) are built -nightly and hosted at <https://arrow-r-nightly.s3.amazonaws.com>. To +nightly and hosted at <https://nightlies.apache.org/arrow/r>. To Review Comment: https://nightlies.apache.org/arrow/r does a 301 redirect to https://nightlies.apache.org/arrow/r/ so everywhere there is a URL that CRAN may check, we need the trailing slash. ```suggestion nightly and hosted at <https://nightlies.apache.org/arrow/r/>. To ``` ########## r/vignettes/developers/install_details.Rmd: ########## @@ -94,13 +94,14 @@ you'll need to install them before installing the R package. If libarrow is not found on the system, the R package installation script will next attempt to download prebuilt libarrow binaries -that match your both your local operating system and arrow R package version. -The libarrow binaries will only be retrieved if you have set the environment variable -`LIBARROW_BINARY` or `NOT_CRAN`. - -If found, they will be downloaded and bundled when your R package compiles. -For a list of supported distributions and versions, -see the [arrow-r-nightly](https://github.com/ursa-labs/arrow-r-nightly/blob/master/README.md) project. +that match your both your local operating system, required +dependencies (e.g. openssl version) and arrow R package version. + +These are used automatically on many Linux distributions (x86_64 architecture only), +according to the [allowlist](https://github.com/apache/arrow/blob/master/r/tools/nixlibs-allowlist.txt). +If your distribution isn't in the list, you can opt-in by setting the `NOT_CRAN` Review Comment: Could also note here that we welcome PRs to add distros to the allowlist. Although I'm nervous about calling *too* much attention to this feature in the package itself. ########## r/vignettes/developers/setup.Rmd: ########## @@ -69,19 +68,13 @@ brew install apache-arrow --HEAD ### Windows -On Windows, you can download a .zip file containing libarrow from the nightly repository. - -To see what nightlies are available, you can use arrow's (or any other S3 client's) S3 listing functionality to see what is in the bucket `s3://arrow-r-nightly/libarrow/bin`: +On Windows, you can download a .zip file containing libarrow from the +[nightly repository](https://nightlies.apache.org/arrow/r/libarrow/bin/windows). Review Comment: ```suggestion [nightly repository](https://nightlies.apache.org/arrow/r/libarrow/bin/windows/). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
