lidavidm commented on code in PR #13520:
URL: https://github.com/apache/arrow/pull/13520#discussion_r916273653
##########
cpp/src/arrow/filesystem/gcsfs_test.cc:
##########
@@ -105,9 +106,21 @@ class GcsTestbench : public ::testing::Environment {
error += " (exe not found)";
continue;
}
-
- server_process_ = bp::child(exe_path, "-m", "testbench", "--port",
port_, group_);
- if (server_process_.valid() && server_process_.running()) break;
+ // TODO: should I be worried about lifetime of this variable?
+ bp::ipstream output;
+
+ server_process_ = bp::child(exe_path, "-m", "testbench", "--port",
port_, group_,
+ bp::std_err > output);
+ // Wait for message: "* Restarting with"
+ auto testbench_is_running = [&output](bp::child& process) {
+ std::string line;
+ while (process.valid() && process.running() && std::getline(output,
line)) {
+ if (line.find("* Restarting with") != std::string::npos) return true;
+ }
+ return false;
+ };
+
+ if (testbench_is_running(server_process_)) break;
Review Comment:
In the `while` above you could just record the start time and add a time
check to the loop guard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
