vibhatha commented on code in PR #13397:
URL: https://github.com/apache/arrow/pull/13397#discussion_r916625181
##########
r/src/compute-exec.cpp:
##########
@@ -196,8 +226,13 @@ void ExecPlan_Write(
ds::WriteNodeOptions{std::move(opts), std::move(kv)});
StopIfNotOk(plan->Validate());
- StopIfNotOk(plan->StartProducing());
- StopIfNotOk(plan->finished().status());
+ auto result = RunWithCapturedRIfPossible<bool>([&]() -> arrow::Result<bool> {
+ RETURN_NOT_OK(plan->StartProducing());
+ RETURN_NOT_OK(plan->finished().status());
+ return true;
Review Comment:
May be? (please compile and evaluate if it serves the purpose right)
```suggestion
plan->finished().status().ok();
```
##########
r/src/compute-exec.cpp:
##########
@@ -196,8 +226,13 @@ void ExecPlan_Write(
ds::WriteNodeOptions{std::move(opts), std::move(kv)});
StopIfNotOk(plan->Validate());
- StopIfNotOk(plan->StartProducing());
- StopIfNotOk(plan->finished().status());
+ auto result = RunWithCapturedRIfPossible<bool>([&]() -> arrow::Result<bool> {
+ RETURN_NOT_OK(plan->StartProducing());
+ RETURN_NOT_OK(plan->finished().status());
+ return true;
Review Comment:
May be? (please compile and evaluate if it serves the purpose right)
```suggestion
return plan->finished().status().ok();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
