alamb commented on code in PR #2005:
URL: https://github.com/apache/arrow-rs/pull/2005#discussion_r916893751
##########
arrow-flight/build.rs:
##########
@@ -88,6 +88,13 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
file.write_all(buffer.as_bytes())?;
}
+ // Prost currently generates an empty file, this was fixed but then
reverted
+ // https://github.com/tokio-rs/prost/pull/639
+ let google_protobuf_rs = Path::new("src/sql/google.protobuf.rs");
Review Comment:
I was thinking something like
https://doc.rust-lang.org/stable/std/fs/struct.Metadata.html#method.len
I was worrying about some poor soul in the future who expects the file to be
there (because maybe some new version of prost puts something useful in it) but
it is mysteriously deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
