liukun4515 commented on PR #2000: URL: https://github.com/apache/arrow-rs/pull/2000#issuecomment-1180234222
> I see now that @liukun4515 asked to be pinged on this PR for review, which @viirya did but then I merged it prior to @liukun4515 having a chance to review. > > @liukun4515 I will make the 18.0.0 release candidate but if you find issues with the API or some other reason we should not release 18.0.0 with this change in it, please let me know and we can make changes prior to release. > I see now that @liukun4515 asked to be pinged on this PR for review, which @viirya did but then I merged it prior to @liukun4515 having a chance to review. > > @liukun4515 I will make the 18.0.0 release candidate but if you find issues with the API or some other reason we should not release 18.0.0 with this change in it, please let me know and we can make changes prior to release. Sorry for the later reply, I am busy with other task. This pr looks great for me. And from https://github.com/apache/arrow-rs/pull/2000#discussion_r916386516, it's better to refactor the builder and generate the array data from `fixed list builder` to `fixed binary builder`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
