tustvold commented on code in PR #2045:
URL: https://github.com/apache/arrow-rs/pull/2045#discussion_r918373838
##########
parquet/src/file/statistics.rs:
##########
@@ -341,21 +393,24 @@ impl fmt::Display for Statistics {
}
/// Typed implementation for [`Statistics`].
-#[derive(Clone)]
-pub struct TypedStatistics<T: DataType> {
- min: Option<T::T>,
- max: Option<T::T>,
+pub type TypedStatistics<T> = ValueStatistics<<T as DataType>::T>;
Review Comment:
It is needed so you can create Statistics from a T: ParquetValueType,
whereas previously it was being created (in a very hacky way) using DataType
and casting via byte slices
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
