jvanstraten commented on code in PR #13528:
URL: https://github.com/apache/arrow/pull/13528#discussion_r918390553


##########
cpp/src/arrow/engine/substrait/relation_internal.cc:
##########
@@ -215,16 +220,24 @@ Result<compute::Declaration> FromProto(const 
substrait::Rel& rel,
       }
       ARROW_ASSIGN_OR_RAISE(auto input, FromProto(project.input(), ext_set));
 
+      // NOTE: Substrait ProjectRels *append* columns, while Acero's project 
node replaces
+      // them. Therefore, we need to prefix all the current columns for 
compatibility.
       std::vector<compute::Expression> expressions;

Review Comment:
   96f8c93



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to