westonpace commented on PR #13334: URL: https://github.com/apache/arrow/pull/13334#issuecomment-1180981887
> @pitrou do you know why the output of operation() on sorting is NullPartitionResult when the indices sorted array references are indices_begin and indices_begin? Why don't just return and Status instead? > > Result<NullPartitionResult> operator()(uint64_t* indices_begin, uint64_t* indices_end, > const Array& array, int64_t offset, > const ArraySortOptions& options) > > And, if NullPartitionResult is needed, why it is not assigned on [ArraySortIndices](https://github.com/ArianaVillegas/arrow/blob/b4b0bd4a96cb37628f4a6742800bbddf7f26deaa/cpp/src/arrow/compute/kernels/vector_array_sort.cc#L525)? @ArianaVillegas `GetArraySorter` is also used in [RankInternal](https://github.com/apache/arrow/blob/66b0d2a999c8d817fade056e625e4d3ff92a4fff/cpp/src/arrow/compute/kernels/vector_sort.cc#L175) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
