thisisnic commented on code in PR #13514:
URL: https://github.com/apache/arrow/pull/13514#discussion_r918835911
##########
r/tests/testthat/test-Table.R:
##########
@@ -696,3 +696,18 @@ test_that("as_arrow_table() errors for invalid input", {
class = "arrow_no_method_as_arrow_table"
)
})
+
+test_that("num_rows method not susceptible to integer overflow", {
Review Comment:
I've removed the RecordBatch test, added in tests for a few more fields, as
well as updating a couple of utility functions that these changes broke. The
one thing I didn't do is getting `array$data()` and actually, I'm wondering if
overflow is possible with that? From my understanding, an array's maximum size
would be the maximum integer value, or am I getting mixed up there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
