iChauster commented on PR #13426: URL: https://github.com/apache/arrow/pull/13426#issuecomment-1182280883
@icexelloss @westonpace unmarking as draft. Got around to finalizing the data generation scripts and the initial version of the documentation. I also cleaned up the file and removed some unused utilities. I have left in the HashJoin benchmarks for now. I have also included implementation for two source nodes -- a TableSourceNode and a source node with a `RecordBatchFileReader.` Per our discussion on the mailing list these sort of benchmark two different things and I am not sure if we should choose one or do both for our benchmarks. Currently, I am using the table implementation (however these are quite interchangeable). Lastly, I added a memory statistic, using `memory_pool()->max_memory()`, however the results seem pretty constant between the different benchmarks. Let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
