lidavidm commented on code in PR #13599:
URL: https://github.com/apache/arrow/pull/13599#discussion_r921097731
##########
docker-compose.yml:
##########
@@ -1214,6 +1216,8 @@ services:
shm_size: *shm-size
environment:
<<: *ccache
+ ARROW_BUILD_STATIC: 'ON'
Review Comment:
Ah, right. Removed, also updated Flight's CMakeLists.txt to not perform the
check added above if we're not building tests.
##########
docker-compose.yml:
##########
@@ -487,7 +487,9 @@ services:
<<: *ccache
CC: clang-${CLANG_TOOLS}
CXX: clang++-${CLANG_TOOLS}
- ARROW_BUILD_STATIC: "OFF"
+ # ARROW-17051: this build uses static Protobuf, so we must also
+ # use static Arrow to run Flight/Flight SQL tests
+ ARROW_BUILD_STATIC: "ON"
Review Comment:
I'll move it. 22.04 is also too old (3.12, we want 3.15):
https://packages.ubuntu.com/jammy/libprotobuf-dev
##########
docker-compose.yml:
##########
@@ -487,7 +487,9 @@ services:
<<: *ccache
CC: clang-${CLANG_TOOLS}
CXX: clang++-${CLANG_TOOLS}
- ARROW_BUILD_STATIC: "OFF"
+ # ARROW-17051: this build uses static Protobuf, so we must also
+ # use static Arrow to run Flight/Flight SQL tests
+ ARROW_BUILD_STATIC: "ON"
Review Comment:
I moved it. 22.04 is also too old (3.12, we want 3.15):
https://packages.ubuntu.com/jammy/libprotobuf-dev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
