alamb opened a new pull request, #2914: URL: https://github.com/apache/arrow-datafusion/pull/2914
# Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/2913 # Rationale for this change I am working on https://github.com/apache/arrow-datafusion/pull/2891 and it was not clear there were existing `ScalarValue` tests because they were in a different module than their implementation Implementation: https://github.com/apache/arrow-datafusion/blob/fd64e6f2e5ca5ba8c33c431b75a3ba9441091970/datafusion/common/src/scalar.rs Tests https://github.com/apache/arrow-datafusion/blob/85ca8be669dc1fbba4b2eefbf99fc2ed1546cc0c/datafusion/core/src/scalar.rs 🤯 # What changes are included in this PR? 1. Move `ScalarValue` tests alongside implementation 2. move `from_slice` to `datafusion_core` (as it is used in the ScalarValue implementation) # Are there any user-facing changes? `from_slice` is now in the `datafusion_core` crate (used to be in `datafusion_physical_expr` crate), but their is a `pub use` so no existing code needs to be changed (they can still import `from_slice` from `datafusion_physical_expr`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
