thisisnic commented on code in PR #12826: URL: https://github.com/apache/arrow/pull/12826#discussion_r921929327
########## r/src/compute-exec.cpp: ########## @@ -146,20 +146,12 @@ std::shared_ptr<compute::ExecNode> ExecNode_Scan( options->dataset_schema = dataset->schema(); - // ScanNode needs the filter to do predicate pushdown and skip partitions - options->filter = ValueOrStop(filter->Bind(*dataset->schema())); Review Comment: I'm not sure this is right. I got rid of this to remove the call to `Bind()` but it looks like this chunk of code has more purposes than just that? I was thinking it might just need the variable `filter` adding into `options`, but wasn't sure how to do that. I tried `options->filter = ValueOrStop(filter);` but got an error about `ValueOrStop` not being defined. I also tried `options->filter = filter;` but get `no viable overloaded '='`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
