tustvold commented on code in PR #2892:
URL: https://github.com/apache/arrow-datafusion/pull/2892#discussion_r922690494
##########
datafusion/proto/Cargo.toml:
##########
@@ -33,18 +33,24 @@ name = "datafusion_proto"
path = "src/lib.rs"
[features]
+default = []
+json = ["pbjson", "pbjson-build", "serde", "serde_json"]
[dependencies]
arrow = { version = "18.0.0" }
datafusion = { path = "../core", version = "10.0.0" }
datafusion-common = { path = "../common", version = "10.0.0" }
datafusion-expr = { path = "../expr", version = "10.0.0" }
prost = "0.10"
-
+serde = { version = "1.0", optional = true }
+serde_json = { version = "1.0", optional = true }
+pbjson = { version = "0.3", optional = true }
+pbjson-types = { version = "0.3", optional = true }
[dev-dependencies]
doc-comment = "0.3"
tokio = "1.18"
[build-dependencies]
-tonic-build = { version = "0.7" }
+pbjson-build = { version = "0.3", optional = true }
+prost-build = { version = "0.7" }
Review Comment:
There was actually no reason for this to depend on tonic-build, and not just
prost-build. This is likely an orphan from when ballista was extracted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
