AlenkaF commented on code in PR #13311: URL: https://github.com/apache/arrow/pull/13311#discussion_r922972234
########## python/pyarrow/src_arrow/CMakeLists.txt: ########## @@ -0,0 +1,447 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# +# arrow_python +# + +cmake_minimum_required(VERSION 3.5) + +# RPATH settings on macOS do not affect install_name. +# https://cmake.org/cmake/help/latest/policy/CMP0068.html +if(POLICY CMP0068) + cmake_policy(SET CMP0068 NEW) +endif() + +# +# Define +# ARROW_SOURCE_DIR: location of arrow/cpp +# CMAKE_MODULE_PATH: location of cmake_modules in python +# + +get_filename_component(PYARROW_SOURCE_DIR ${CMAKE_SOURCE_DIR} DIRECTORY) +get_filename_component(PYTHON_SOURCE_DIR ${PYARROW_SOURCE_DIR} DIRECTORY) +get_filename_component(ARROW_SOURCE ${PYTHON_SOURCE_DIR} DIRECTORY) +set(ARROW_CPP_SOURCE_DIR "${ARROW_SOURCE}/cpp") +set(ARROW_SOURCE_DIR "${ARROW_CPP_SOURCE_DIR}") + +# normalize ARROW_HOME path +file(TO_CMAKE_PATH "$ENV{ARROW_HOME}" ARROW_HOME) +set(CMAKE_MODULE_PATH "${PYTHON_SOURCE_DIR}/cmake_modules" "${ARROW_HOME}/lib/cmake/arrow") + +# +# Arrow version +# + +set(ARROW_PYTHON_VERSION "9.0.0-SNAPSHOT") +string(REGEX MATCH "^[0-9]+\\.[0-9]+\\.[0-9]+" ARROW_PYTHON_BASE_VERSION "${ARROW_PYTHON_VERSION}") +# Need to set to ARRROW_VERSION before finding Arrow package! +project(arrow_python VERSION "${ARROW_PYTHON_BASE_VERSION}") + +if(NOT DEFINED CMAKE_BUILD_TYPE) + set(CMAKE_BUILD_TYPE Release) +endif() + +# +# Arrow +# + +find_package(Arrow REQUIRED) +include(ArrowOptions) + +# +# Python +# +# Use the first Python installation on PATH, not the newest one +set(Python3_FIND_STRATEGY "LOCATION") +# On Windows, use registry last, not first +set(Python3_FIND_REGISTRY "LAST") +# On macOS, use framework last, not first +set(Python3_FIND_FRAMEWORK "LAST") + +find_package(Python3Alt 3.7 REQUIRED) +include_directories(SYSTEM ${NUMPY_INCLUDE_DIRS} ${PYTHON_INCLUDE_DIRS} src) + +add_custom_target(arrow_python-all) +add_custom_target(arrow_python) +add_custom_target(arrow_python-tests) +add_dependencies(arrow_python-all arrow_python arrow_python-tests) + +set(ARROW_PYTHON_SRCS + arrow_to_pandas.cc + benchmark.cc + common.cc + datetime.cc + decimal.cc + deserialize.cc + extension_type.cc + gdb.cc + helpers.cc + inference.cc + init.cc + io.cc + ipc.cc + numpy_convert.cc + numpy_to_arrow.cc + python_to_arrow.cc + pyarrow.cc + serialize.cc + udf.cc) + +set_source_files_properties(init.cc PROPERTIES SKIP_PRECOMPILE_HEADERS ON + SKIP_UNITY_BUILD_INCLUSION ON) + +# +# Arrow vs C PyArrow options +# + +# Check all the options from Arrow and C PyArrow to be in line +if(PYARROW_WITH_DATASET) + find_package(ArrowDataset REQUIRED) +endif() + +if(PYARROW_WITH_PARQUET_ENCRYPTION) + if(PARQUET_REQUIRE_ENCRYPTION) + list(APPEND ARROW_PYTHON_SRCS parquet_encryption.cc) + find_package(Parquet REQUIRED) + else() + message(FATAL_ERROR "You must build Arrow C++ with PARQUET_REQUIRE_ENCRYPTION=ON") + endif() +endif() + +if(PYARROW_WITH_HDFS) + if(NOT ARROW_HDFS) + message(FATAL_ERROR "You must build Arrow C++ with ARROW_HDFS=ON") + endif() +endif() + +# Check for only Arrow C++ options +if(ARROW_CSV) + list(APPEND ARROW_PYTHON_SRCS csv.cc) +endif() + +if(ARROW_FILESYSTEM) + list(APPEND ARROW_PYTHON_SRCS filesystem.cc) +endif() + +# Link to arrow dependecies +if(ARROW_BUILD_SHARED) + set(ARROW_PYTHON_DEPENDENCIES arrow_shared) +else() + set(THREADS_PREFER_PTHREAD_FLAG ON) + find_package(Threads REQUIRED) + set(ARROW_PYTHON_DEPENDENCIES arrow_static Threads::Threads) +endif() + +if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" OR CMAKE_CXX_COMPILER_ID STREQUAL "Clang") + set_property(SOURCE pyarrow.cc + APPEND_STRING + PROPERTY COMPILE_FLAGS " -Wno-cast-qual ") +endif() + +# +# Compiler stuff +# + +include(GNUInstallDirs) + +# This ensures that things like gnu++11 get passed correctly +if(NOT DEFINED CMAKE_CXX_STANDARD) + set(CMAKE_CXX_STANDARD 11) +endif() + +# We require a C++11 compliant compiler +set(CMAKE_CXX_STANDARD_REQUIRED ON) + +# Needed gdb flags +include(SetupCxxFlags) + +# +# shred/static link libs +# + +set(ARROW_PYTHON_SHARED_LINK_LIBS arrow_shared) +set(ARROW_PYTHON_SHARED_PRIVATE_LINK_LIBS) +set(ARROW_PYTHON_STATIC_LINK_LIBS ${PYTHON_OTHER_LIBS}) + +if(WIN32) + list(APPEND ARROW_PYTHON_SHARED_LINK_LIBS ${PYTHON_LIBRARIES} ${PYTHON_OTHER_LIBS}) +endif() + +if(PARQUET_REQUIRE_ENCRYPTION AND PYARROW_WITH_PARQUET_ENCRYPTION) Review Comment: I added `PYARROW_WITH_PARQUET_ENCRYPTION` in this commit: https://github.com/apache/arrow/pull/13311/commits/c56fbe222b1f5fd2d40410c4e522a4fb114efbcd because there is a case where we build with `PARQUET_REQUIRE_ENCRYPTION=on` but `PYARROW_WITH_PARQUET=off` and so `PYARROW_WITH_PARQUET_ENCRYPTION` is set to off due to Parquet not being built and not loaded: https://github.com/apache/arrow/blob/385fe4315b2ccefc90860cee18a3661f67b57c3e/python/pyarrow/src_arrow/CMakeLists.txt#L117-L124 See failing build: https://github.com/apache/arrow/runs/7229978593?check_suite_focus=true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
