AlenkaF commented on code in PR #13629:
URL: https://github.com/apache/arrow/pull/13629#discussion_r923145585


##########
python/pyarrow/tests/parquet/test_metadata.py:
##########
@@ -531,3 +532,19 @@ def test_metadata_exceeds_message_size():
         buf = out.getvalue()
 
     metadata = pq.read_metadata(pa.BufferReader(buf))
+
+
+def test_metadata_schema_filesystem(tmpdir):
+    table = pa.table({"a": [1, 2, 3]})
+
+    # URI writing to local file.
+    file_path = 'file:///' + os.path.join(str(tmpdir), "data.parquet")
+
+    pq.write_table(table, file_path)
+
+    # Get expected `metadata` from path.
+    metadata = pq.read_metadata(tmpdir / '/data.parquet')

Review Comment:
   Hm, I guess so. As `file_path` is a URI and you are reading from direct 
path, you are also checking that the filesystem is selected correctly.
   
   When thinking about it I wondered if it would be good to also add a test 
with supplying a `filesystem=fs.LocalFileSystem()` to `read_metadata` and 
`read_schema` (or maybe some other to catch an error)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to