Ted-Jiang commented on code in PR #2105:
URL: https://github.com/apache/arrow-rs/pull/2105#discussion_r924039924
##########
parquet/src/arrow/array_reader/byte_array_dictionary.rs:
##########
@@ -346,6 +346,7 @@ where
// Keys will be validated on conversion to arrow
let keys_slice = keys.spare_capacity_mut(range.start +
len);
let len = decoder.get_batch(&mut
keys_slice[range.start..])?;
+ *max_remaining_values -= len;
Review Comment:
miss this will fail at record skip count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
