pitrou commented on code in PR #13567:
URL: https://github.com/apache/arrow/pull/13567#discussion_r924253359
##########
cpp/src/arrow/dataset/partition_test.cc:
##########
@@ -426,6 +456,41 @@ TEST_F(TestPartitioning, HivePartitioning) {
AssertParseError("/alpha=0.0/beta=3.25/"); // conversion of "0.0" to int32
fails
}
+TEST_F(TestPartitioning, HivePartitioningEquals) {
+ const auto& array_vector = ArrayVector();
+ std::vector<std::shared_ptr<arrow::Array>> other_vector(2);
+ other_vector.push_back(ArrayFromJSON(utf8(), R"(["foo", "bar", "baz"])"));
+ other_vector.push_back(ArrayFromJSON(utf8(), R"(["bar", "foo", "baz"])"));
Review Comment:
Er, this is creating a vector of size 4 with the first two values
zero-initialized, AFAIU.
```suggestion
ArrayVector other_vector(2);
other_vector[0] = ArrayFromJSON(utf8(), R"(["foo", "bar", "baz"])");
other_vector[1] = ArrayFromJSON(utf8(), R"(["bar", "foo", "baz"])");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
