wesm commented on code in PR #13630:
URL: https://github.com/apache/arrow/pull/13630#discussion_r924520932
##########
cpp/src/arrow/compute/row/grouper.cc:
##########
@@ -294,20 +282,21 @@ struct GrouperFastImpl : Grouper {
ctx_->memory_pool()));
}
}
- return ConsumeImpl(expanded);
+ return ConsumeImpl(ExecSpan(expanded));
}
}
return ConsumeImpl(batch);
}
- Result<Datum> ConsumeImpl(const ExecBatch& batch) {
+ Result<Datum> ConsumeImpl(const ExecSpan& batch) {
int64_t num_rows = batch.length;
int num_columns = batch.num_values();
// Process dictionaries
for (int icol = 0; icol < num_columns; ++icol) {
if (key_types_[icol].id() == Type::DICTIONARY) {
- auto data = batch[icol].array();
- auto dict = MakeArray(data->dictionary);
+ const ArraySpan& data = batch[icol].array;
+ // TODO(wesm): do not require ToArrayData here
Review Comment:
Removed the comment for now, each of the usages of `ToArrayData` can be
given consideration in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
