nealrichardson commented on PR #12826: URL: https://github.com/apache/arrow/pull/12826#issuecomment-1189322402
Re: the print method, you probably need more special casing [here](https://github.com/apache/arrow/blob/master/r/R/dplyr.R#L117). The other place that may make assumptions about FieldRefs is `implicit_schema()`, which is called when a query is collapsed. So you may want to add some tests that do aggregation, or joins, or head/tail, etc., as these are all cases that would involve implicit_schema (iirc). Re: handling for non-Datasets, ideally you'd catch that when `add_filename()` is called. You should be able to find `.data` somewhere in the env stack and inspect it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
