tustvold opened a new pull request, #2116:
URL: https://github.com/apache/arrow-rs/pull/2116
# Which issue does this PR close?
Part of #2107
# Rationale for this change
The original logic is very confusing as it determines whether to use a
packed decoder, based on the type of DefinitionLevelBuffer passed to
`DefinitionLevelBufferDecoder`. Not only is this confusing, but it creates a
problem when skipping the first records in a column chunk, as the type of
decoder is not known until data has been read :scream:
This largely dated from a time when `GenericRecordReader` was generic over
the levels in addition to values. In the end I removed this prior to merge as
it was unnecessary complexity.
# What changes are included in this PR?
Explicitly construct the decoders in GenericRecordReader, and passes them to
`GenericColumnReader::new_with_decoders`. This allows adding an additional
constructor parameter to `DefinitionLevelBufferDecoder` to instruct it whether
to decode packed or not.
# Are there any user-facing changes?
No, all these traits are crate private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
