nevi-me commented on a change in pull request #8204:
URL: https://github.com/apache/arrow/pull/8204#discussion_r490879919
##########
File path: rust/arrow/src/compute/kernels/boolean.rs
##########
@@ -123,9 +125,78 @@ pub fn not(left: &BooleanArray) -> Result<BooleanArray> {
Ok(BooleanArray::from(Arc::new(data)))
}
+pub fn is_null(input: &ArrayRef) -> Result<BooleanArray> {
+ if input.offset() % 8 != 0 {
Review comment:
Oh yes, I remember that now. I tried looking at bit manipulation that
would address this, but I can't remember where; maybe as part of the Parquet
writer 🤔
It's def something that we need to do, if I have more time in the coming
months I'll look into it. We could also take inspiration from c++ as I think
they have this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
