westonpace commented on code in PR #13518:
URL: https://github.com/apache/arrow/pull/13518#discussion_r927812785
##########
cpp/src/arrow/dataset/scanner_test.cc:
##########
@@ -1358,16 +1359,19 @@ DatasetAndBatches DatasetAndBatchesFromJSON(
const std::shared_ptr<Schema>& dataset_schema,
const std::shared_ptr<Schema>& physical_schema,
const std::vector<std::vector<std::string>>& fragment_batch_strs,
- const std::vector<compute::Expression>& guarantees,
- std::function<void(compute::ExecBatch*, const RecordBatch&)>
make_exec_batch = {}) {
+ const std::vector<compute::Expression>& guarantees) {
+ // Expect a guarantee expr for each test fragment
Review Comment:
```suggestion
// If guarantees are provided we must have one for each batch
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
