alamb commented on code in PR #2168:
URL: https://github.com/apache/arrow-rs/pull/2168#discussion_r929316077
##########
.github/workflows/rust.yml:
##########
@@ -88,36 +69,6 @@ jobs:
cargo check -p parquet --no-default-features --all-targets
cargo check -p parquet --no-default-features --features arrow
--all-targets
- # test the --features "simd" of the arrow crate. This requires nightly.
- linux-test-simd:
- name: Test SIMD on AMD64 Rust ${{ matrix.rust }}
- runs-on: ubuntu-latest
- strategy:
- matrix:
- arch: [ amd64 ]
- rust: [ nightly ]
- container:
- image: ${{ matrix.arch }}/rust
- env:
- # Disable full debug symbol generation to speed up CI build and keep
memory down
- # "1" means line tables only, which is useful for panic tracebacks.
- RUSTFLAGS: "-C debuginfo=1"
- ARROW_TEST_DATA: /__w/arrow-rs/arrow-rs/testing/data
- steps:
- - uses: actions/checkout@v2
- with:
- submodules: true
- - name: Setup Rust toolchain
- uses: ./.github/actions/setup-builder
- with:
- rust-version: ${{ matrix.rust }}
- - name: Run tests
- run: |
- cargo test -p arrow --features "simd"
- - name: Check compilation with simd features
- run: |
- cargo check -p arrow --features simd
- cargo check -p arrow --features simd --all-targets
windows-and-macos:
Review Comment:
I am not quite sure what to do with windows and mac which run in the `Rust`
workflow now -- I am thinking perhaps I could change the CI to run just the
jobs for each crate individually for mac 🤔
##########
.github/workflows/rust.yml:
##########
@@ -54,25 +54,6 @@ jobs:
run: |
# run tests on all workspace members with default feature list
cargo test
Review Comment:
Technically speaking this still runs tests for arrow in the main rust flow
as well -- I plan to remove this over time
##########
.github/workflows/arrow.yml:
##########
@@ -0,0 +1,159 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# tests for arrow crate
+name: Arrow
+
+on:
+ # always trigger
+ push:
+ branches:
+ - master
+ pull_request:
+
+jobs:
+
+ # test the crate
+ linux-test:
+ name: Test
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ env:
+ # Disable full debug symbol generation to speed up CI build and keep
memory down
+ # "1" means line tables only, which is useful for panic tracebacks.
+ RUSTFLAGS: "-C debuginfo=1"
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ submodules: true
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup-builder
+ with:
+ rust-version: stable
+ - name: Test default features
Review Comment:
these tests are moved from the main Rust.yml `test` omnibus test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
