jonkeane commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r929950020
##########
r/tests/testthat/helper-skip.R:
##########
@@ -70,6 +70,10 @@ skip_if_not_dev_mode <- function() {
}
skip_if_not_running_large_memory_tests <- function() {
+ if (force_tests()) {
Review Comment:
For testing that `force_tests()` does actually force all the tests, we might
put in an explicitly bad test (I usually do `expect_true(false)` or the like).
IIUC, the OOM here isn't 100% deterministic so relying on that to be the thing
that fails might be a bit frustrating
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
