waitingkuo commented on code in PR #2942:
URL: https://github.com/apache/arrow-datafusion/pull/2942#discussion_r931464136
##########
datafusion/physical-expr/src/math_expressions.rs:
##########
@@ -176,11 +176,39 @@ pub fn power(args: &[ArrayRef]) -> Result<ArrayRef> {
}
}
+pub fn atan2(args: &[ArrayRef]) -> Result<ArrayRef> {
+ // FIXME other data_type?
Review Comment:
i implemented f64 first and left this to remind me to implement f32. it
turns out that i need another reminder to delete this comment...
fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
