marsupialtail commented on code in PR #13662:
URL: https://github.com/apache/arrow/pull/13662#discussion_r931528167
##########
cpp/src/arrow/util/io_util.cc:
##########
@@ -1115,7 +1116,9 @@ Result<FileDescriptor> FileOpenWritable(const
PlatformFilename& file_name,
fd = FileDescriptor(ret);
#else
int oflag = O_CREAT;
-
+ if (sync) {
+ oflag |= O_SYNC;
Review Comment:
Yes I think O_DSYNC probably makes more sense. I think there might be other
cases in which you want to open a file with O_DSYNC where you are not using
fadvise. So perhaps having a separate flag here is good for future use cases.
Although I am struggling to think of one right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
