iChauster commented on code in PR #13426: URL: https://github.com/apache/arrow/pull/13426#discussion_r931535508
########## cpp/src/arrow/compute/exec/test_util.h: ########## @@ -145,5 +145,40 @@ class Random64Bit { std::uniform_int_distribution<uint64_t> dist_; }; +/// Specify properties of a table to be generated. +struct TableGenerationProperties { + /// Indicates the amount of time between data points that lie between + /// the start and end parameters. + int time_frequency; + /// The number of additional random columns in the table. + int num_columns; + /// The number of unique keys in the table. + int num_ids; + /// Specifies the prefix of each randomly generated column. + std::string column_prefix; + /// Specifies the minimum value in the randomly generated column(s). + int min_column_value; + /// Specifies the maximum value in the randomly generated column(s). + int max_column_value; + /// The random seed the random array generator is given to generate the additional + /// columns. + int seed; + /// Specifies the beginning of 'time' recorded in the table, inclusive. + int start; + /// Specifies the end of 'time' recorded in the table, inclusive. + int end; +}; + +/// The table generated in accordance to the TableGenerationProperties has the following +/// schema: time (int64) id (int32) [properties.column_prefix]0 (float64) Review Comment: That's good, added a definition for the range for idx and removed the other redundant lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org