tustvold commented on PR #2195: URL: https://github.com/apache/arrow-rs/pull/2195#issuecomment-1197366211
> I think some might say it is not "idomatic" Rust in that it doesn't use the more functional map / ok type style I think using structured matches as this PR does is idiomatic Rust and I'm happy with it, nice work :+1:. FWIW I don't think code needs to be written in a functional style to be considered idiomatic, it is frequently harder to understand, and very often the borrow checker prevents it anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
