liukun4515 commented on code in PR #2977:
URL: https://github.com/apache/arrow-datafusion/pull/2977#discussion_r933708427


##########
datafusion/core/tests/parquet_pruning.rs:
##########
@@ -449,6 +450,154 @@ async fn prune_int32_eq_in_list_negated() {
     assert_eq!(output.result_rows, 19, "{}", output.description());
 }
 
+async fn test_prune_decimal(

Review Comment:
   Sorry for the confused comments.
   When I work on the decimal test, and find all the `pruning test` has the 
common logic.
   I can collation them in the next pr.
   ```
   async test_prune(
       case_type: Scenario,
       sql: &str,
       expected_errors: Option<usize>,
       expected_row_group_pruned: Option<usize>,
       expected_results: usize) -> {}
   ```
   All the test cases such as `prune_f64_lt`,`prune_i64_lt` can use 
`test_prune` to replace the repeated logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to