Ted-Jiang commented on code in PR #2237:
URL: https://github.com/apache/arrow-rs/pull/2237#discussion_r933755699
##########
parquet/src/arrow/array_reader/null_array.rs:
##########
@@ -80,8 +80,15 @@ where
/// Reads at most `batch_size` records into array.
fn next_batch(&mut self, batch_size: usize) -> Result<ArrayRef> {
- read_records(&mut self.record_reader, self.pages.as_mut(),
batch_size)?;
+ let size = self.read_records(batch_size)?;
Review Comment:
IMO, i think we can keep `next_batch` , it just use `read_records` and
`consume_batch` in order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
