alamb opened a new pull request, #3026: URL: https://github.com/apache/arrow-datafusion/pull/3026
NOTE: This change looks large but it is only moving code around # Which issue does this PR close? re https://github.com/apache/arrow-datafusion/issues/1474 # Rationale for this change I find it really hard to work on `binary.rs`. Partly this is because what it is doing is complicated however, I think it can be less complicated than currently, and thus I am trying to unravel the [Gordian knot](https://www.merriam-webster.com/dictionary/Gordian%20knot) Part of why this module is complicated is because it has both dispatch logic (figure out what functions to call based on argument types) as well as kernel implementations (both stuff that should eventually end up in arrow as well as things that are datafusion specific). I think it will be easier to work with if the file were smaller. # What changes are included in this PR? Thus, break binary.rs into several smaller modules: * `binary.rs`: The main dispatch logic * `binary/kernels.rs`: kernels that are unique to datafusion * `binary/arrow_kernels.rs`: Kernels that are eventually destined for arrow-rs but are in datafusion until we get around tot hat * `binary/adapte.rs`: functions that might change types or names to make them compatible with the main dispatch logic # Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
